vhive-serverless / invitro

Load generator and trace sampler for serverless computing
MIT License
16 stars 9 forks source link

`go mod tidy` fails to run #311

Closed leokondrashov closed 3 months ago

leokondrashov commented 10 months ago

Version & Branch

main branch

Expected Behaviour

Successfully run go mod tidy

Actual Behaviour

Failure:

github.com/vhive-serverless/loader/pkg/driver imports
        go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
        go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
        google.golang.org/grpc/interop imports
        golang.org/x/oauth2/google imports
        cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
        cloud.google.com/go v0.99.0 (/users/lkondras/go/pkg/mod/cloud.google.com/go@v0.99.0/compute/metadata)
        cloud.google.com/go/compute/metadata v0.2.3 (/users/lkondras/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.2.3)

Steps to Reproduce the Problem

  1. Create the cluster (maybe it is enough to install go1.19.4)
  2. Run go mod tidy twice (first one removes one line from go.mod, second one fails)

Additional Info

git diff for changed files by go mod tidy:

diff --git a/go.mod b/go.mod
index 143cf55..37401bd 100644
--- a/go.mod
+++ b/go.mod
@@ -22,7 +22,6 @@ require (
)
require (
-       cloud.google.com/go/compute/metadata v0.2.3 // indirect
        git.sr.ht/~sbinet/gg v0.4.1 // indirect
        github.com/ajstarks/svgo v0.0.0-20211024235047-1546f124cd8b // indirect
        github.com/davecgh/go-spew v1.1.1 // indirect
diff --git a/go.sum b/go.sum
index 36af673..f36d3fa 100644
--- a/go.sum
+++ b/go.sum
@@ -3,7 +3,6 @@ cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
cloud.google.com/go v0.99.0 h1:y/cM2iqGgGi5D5DQZl6D9STN/3dR/Vx5Mp8s752oJTY=
cloud.google.com/go/compute v1.23.0 h1:tP41Zoavr8ptEqaW6j+LQOnyBBhO7OkOMAGrgLopTwY=
cloud.google.com/go/compute/metadata v0.2.3 h1:mg4jlk7mCAj6xXp9UJ4fjI9VUI5rubuGBW5aJ7UnBMY=
-cloud.google.com/go/compute/metadata v0.2.3/go.mod h1:VAV5nSsACxMJvgaAuX6Pk2AawlZn8kiOGuCv6gTkwuA=
git.sr.ht/~sbinet/cmpimg v0.1.0 h1:E0zPRk2muWuCqSKSVZIWsgtU9pjsw3eKHi8VmQeScxo=
git.sr.ht/~sbinet/gg v0.4.1 h1:YccqPPS57/TpqX2fFnSRlisrqQ43gEdqVm3JtabPrp0=
git.sr.ht/~sbinet/gg v0.4.1/go.mod h1:xKrQ22W53kn8Hlq+gzYeyyohGMwR8yGgSMlVpY/mHGc=
leokondrashov commented 3 months ago

At some point, the bump of go version fixed the issue, I guess