Eliminate bash scripts dependencies

vhive-serverless / vHive

vHive: Open-source framework for serverless experimentation

MIT License

263 stars 84 forks source link

Eliminate bash scripts dependencies #835

Open flyinghorse0510 opened 9 months ago

flyinghorse0510 commented 9 months ago

Currently there exists some complicated dependencies between some setup bash scripts, like the figure shown below:

Actually, most of them have been rewritten with Go, but to remove them completely, some modifications of files under scripts/github_runner directory need to be applied

FYI, below are lists of bash scripts which have been rewritten and should have been removed if dependency issues were fixed:

scripts/setup_system.sh
scripts/setup_gvisor_containerd.sh
scripts/install_go.sh
scripts/setup_firecracker_containerd.sh
scripts/install_stock.sh
scripts/install_pmutools.sh
scripts/setup_node.sh

ustiugov commented 9 months ago

can you be more specific on what was rewritten and what wasn't?

flyinghorse0510 commented 9 months ago

can you be more specific on what was rewritten and what wasn't?

Yeah, Scripts have been rewritten: All scripts under scripts/cloudlab All scripts under scripts/cluster All scripts under scripts/ except clean_cri_runner.sh, create_devmapper.sh, and clean_fcctr.sh Additionally, scripts/github_runner/setup_cri_test_env.sh has been adapted to use Go scripts

All other scripts under scripts and its sub-directories left untouched

ustiugov commented 9 months ago

can you please update the PR's description and enumerate the scripts that still need to be eliminated. this issue is not about what was already rewritten but what needs to.

leokondrashov commented 6 days ago

I don't think that's completely done. If I remember correctly, we still have shell scripts for setting up the cri runners.