vhive-serverless / vHive

vHive: Open-source framework for serverless experimentation
MIT License
285 stars 86 forks source link

create prepare_one_node_cluster command #972

Closed wanghanchengchn closed 5 months ago

wanghanchengchn commented 5 months ago

Summary

To better support the deployment and management of single-node Kubernetes clusters, I have created a new command prepare_one_node_cluster. Previously, the create_one_node_cluster command was responsible for both preparing the single-node environment and setting up the master node. Now, I have added a new command called prepare_one_node_cluster. With this new command, users can first prepare the single-node environment, and then manually run setup_master_node to set up the master node when needed. This increased flexibility enables users to selectively execute the relevant steps based on their specific needs.

Implementation Notes :hammer_and_pick:

First, I have split the create_one_node_cluster command into two parts: preparing the single-node environment and setting up the master node. Note that I have only divided the previous create_one_node_cluster command into two functions, without affecting the functionality of the original create_one_node_cluster command.

Subsequently, I have created the prepare_one_node_cluster command, which only runs the first part of the create_one_node_cluster command, i.e., the part responsible for preparing the single-node environment. After running the prepare_one_node_cluster command, users can manually call the setup_master_node command when they need to.

External Dependencies :four_leaf_clover:

N/A

Breaking API Changes :warning:

N/A

lrq619 commented 5 months ago

Hi hancheng, please pass the unit test there

JooyoungPark73 commented 5 months ago

The reason why runner is failing is because we use create one node cluster on other function. https://github.com/vhive-serverless/vHive/blob/cc526822194dc0b725cb6e520bf920b5aae44fb2/scripts/cloudlab/start_onenode_vhive_cluster.go#L121

Please add setup master node there and re-run the checks.