search

vhqtvn / VHEditor-Android

Run Code-server on Android
Other
949 stars 104 forks source link

Unable to change settings #18

Closed eldritchgreene closed 4 years ago

eldritchgreene commented 4 years ago

The pull down menus in the settings do not open/ don't respond to touchscreen so I'm unable to change settings, any way to fix this?

vhqtvn commented 4 years ago

Screenshot_20200714-130501.png I can open it here.What's your device model?

eldritchgreene commented 4 years ago

I can open normal menus fine too, I meant the drop downs within the settings page. I have since managed to change my settings.json file but would be nice to be able to do it from the settings. Screenshot_20200714-111000_2 Otherwise app works great for me so far thank you! Edit: Forgot to add I'm on a Cosmo Communicator.

vhqtvn commented 4 years ago

Oh that setting menu is touch-disabled in vscode server's code, i have to add workaround to forward touch event to mouse event and that worked on my devices: https://github.com/vhqtvn/VHSCode-Android/blob/master/app/src/main/java/vn/vhn/vhscode/CodeServerService.kt#L309 Cosmo is an awesome device but it's extremely hard for me to have access to one, that UI is only pure HTML Dom, can you please try if you can find a workaround for your case?

vhqtvn commented 4 years ago

Actually i updated the workaround, please wait and try 1.1.09 to see if the problem is fixed.

eldritchgreene commented 4 years ago

OK thanks so much!

vhqtvn commented 4 years ago

Hi is it fixed now?

eldritchgreene commented 4 years ago

It's fixed :) thanks again.