vhs / nomos

Membership management system made VHS-centric
25 stars 7 forks source link

dashboard metrics double counting new users #275

Closed laftho closed 4 years ago

laftho commented 4 years ago

Just looked into the member counts on the dashboard, they're wrong as it's more than the last 30 days, it's usually last month + up until today and if that range covers more than 1 month it double counts new members if they have a payment for each of those months crossed in that range.

How we count new members:

The dashboard makes a request as:

I'll make a fix for this and review the other metrics to make sure we aren't double counting in other places.

laftho commented 4 years ago

see https://talk.vanhack.ca/t/qgm-feb-23-2020/10139/7