search

vhs / nomos

Membership management system made VHS-centric
25 stars 7 forks source link

tidy: delete unused pin and rfid *login* code #304

Closed lf- closed 1 month ago

lf- commented 1 year ago

This is all dead code: the ability to log in with pin or rfid was ripped out from the interface in 2015 in e44d9f6f9c38c078daa9a54b3873d178213629e6 but nobody removed the implementation.

I cannot conceive of any use case where being able to log in with either rfid or pin to get your user's privileges is a good idea for security reasons, so we should just remove the code altogether. All the reasonable use cases for these are better served with what was actually built: CheckPin and CheckRfid, executed by a service account on the machine that needs to check pins/rfid credentials and do something based on them.

TyIsI commented 1 month ago

Wait? Are you talking about pin and pinid being removed from the users table?

Because that is due to that functionality moving to the keys table.

lf- commented 1 month ago

Wait? Are you talking about pin and pinid being removed from the users table?

Because that is due to that functionality moving to the keys table.

attempts to remember code from a year ago

i believe that what this code was doing was letting you log into nomos itself with pin or rfid, which was never actually used.

lf- commented 1 month ago

however, it has merge conflicts and i don't expect to get back to it in a reasonable time frame so I'm closing it. i don't really know if i will have the correct energy to touch nomos more in the future.