vhx / quartz-react

Quartz components using React
2 stars 1 forks source link

Chore/reduce logged errors #26

Closed sebastiansandqvist closed 7 years ago

sebastiansandqvist commented 7 years ago

This fixes some minor issues that were causing warnings to be logged to the console.

  1. A missing carousel image caused a 404
  2. The tests were instantiating multiple sidebars, which logged a warning
  3. Checkboxes without an onChange in the demo were missing a readOnly property, so React logged warnings. (I also cleaned up the checkbox component and made it easier to pass in other props to the checkbox input element).
  4. Inputs without an onChange in the demo were causing the same errors as the checkboxes.

We still get a Typekit error since the webfonts won't load, but this is probably only fixable by updating the kit settings on the Typekit website.