vhx / quartz-react

Quartz components using React

2 stars 1 forks source link

CSS-Rewrite: Documentation and component importing #53

Open ninjaofawesome opened 7 years ago

ninjaofawesome commented 7 years ago

OVERVIEW

In this branch I:

updated the readme
added pertinent partials to base.scss
updated normalize

NOTES

I'm not sure we need to import the mixins, as per Quartz's setup. Included but commented
I think we could eliminate base.scss in favor of core.scss serving the same purpose, but will do in a separate ticket.

sebastiansandqvist commented 7 years ago

Can you change the base branch from master to css-rewrite? Hard to tell what changed otherwise

ninjaofawesome commented 7 years ago

@sebastiansandqvist I "bemified" text.scss for review, but I think this is now starting to get into scope creep. However, I have some questions/ideas of what we could do, could be an interesting conversation.

erikmoldovan commented 7 years ago

Heyo. What's left to do before merging? @davegonzalez @ninjaofawesome @sebastiansandqvist

sebastiansandqvist commented 7 years ago

A lot! @ninjaofawesome suggested we have a meeting to discuss in person and I agree we should.

sebastiansandqvist commented 7 years ago

Oops, just to clarify, a lot to do on CSS prior to merging into master but this is totally good for the integration branch IMO. @ninjaofawesome feel free to merge to that branch any time!