vhx / quartz-react

Quartz components using React
2 stars 1 forks source link

[FEATURE] Converted Quartz-React Components to Adventurine, Refactoring. #78

Open ninjaofawesome opened 6 years ago

ninjaofawesome commented 6 years ago

OVERVIEW

This PR converts all of the Quartz-React components away from the original Quartz package whenever possible in favor of using locally hosted styles and Adventurine.

Why would we do this? Many reasons.

Is Quartz completely gone from this repo? No. In some cases, it was easier to leave in the original styles. For example, Modal backgrounds still use Quartz styles- but this could be refactored in future iterations. Also, many of the demo pages feature Quartz styles as those styles are post-compiled.

SOLUTION

NOTES

JIRA TICKET

VHX-1944

erikmoldovan commented 6 years ago

What's the issue with the failing integration?

erikmoldovan commented 6 years ago

Besides the failing specs, this looks good.

As a side comment, it was incredibly hard for me to review this thoroughly since the PR was so large. I read through everything and grasped most of it, but still feel like I don't have a handle on it all.

ninjaofawesome commented 6 years ago

@erikmoldovan Duly noted! In hindsight I think it should have been broken up into many PR's as well. :)