search

vhx / quartz-react

Quartz components using React
2 stars 1 forks source link

Button: fixed attrs test #9

Closed sebastiansandqvist closed 7 years ago

sebastiansandqvist commented 7 years ago

This fixes a broken test for the <Button> component.

The fix corrects the test for the current way the <Button> is written, but I would like to rewrite the button using the proposed excludeProps function in https://github.com/vhx/quartz-react/pull/8 instead of an attrs object.

This is related to my comment here: https://github.com/vhx/quartz-react/pull/2

Using excludeProps we could write a button like: <Button id='123'> Without it, we have to do: <Button attrs={{ id: '123' }}>