Open HeikoKlare opened 1 year ago
The label could also be changed to a static "Toggle Skip All Breakpoints", similar to all the other options.
I changed the state of this issue to Waiting because we need to check with Ed if the proposed solution is even acceptable (it would mean a "big visual change"). @ShahzaibIbrahim please check if the expected behavior (having different icons in the toolbar and in the menu) is even possible.
What was the result of checking with Ed?
Not good: https://github.com/eclipse-platform/eclipse.platform.swt/issues/501#issuecomment-1827826937
At least he didn't reject it so it's up to us to decide.
I say we go ahead with the proposed solution and let the reviewers approve it or reject it. WDYT?
Current behavior:
In Windows 11 (see https://github.com/eclipse-platform/eclipse.platform.swt/issues/501), when Skip All Breakpoints is off (deactivated)
... and when it's on (activated)
Expected behavior:
~We should change the title to Unskip and possibly icon also.~ Propose this and ask Ed Merks (mention him in [the original issue](see https://github.com/eclipse-platform/eclipse.platform.swt/issues/501))
If possible, the icon of the menu (but not then one in the toolbar) should change to a check-mark, like the one in the menu Edit > Smart Insert Mode