search

vi-eclipse / Eclipse-Platform

Umbrella repository for managing a backlog of features/issues related to the Eclipse Platform
2 stars 0 forks source link

Adapt win32 theme calls to use dpi dependent variants #102

Open akoch-yatta opened 4 months ago

akoch-yatta commented 4 months ago

There is already an old branch, that should be doing most of it. But it needs to be retested. https://github.com/akoch-yatta/eclipse.platform.swt/tree/use-dpi-dependent-win32-api-calls

One old issue was positioning of text in the menu items in the menu bar. If the menu bar is not on the primary monitor they will either be too high to or too low´. One proabable solution could be:

  1. Do not forward text to the OS in this case in MenuItem::setText
  2. Draw the text directly via the GC similar to the drawing of the image in MenuItem::wmDrawChild You can check whether the parent Menu has custom drawing enable with Menu::needsMenuCallback
akoch-yatta commented 4 months ago

Master does now contain the neccessary win32 API calls, so I rebased the branch mentioned above onto master.

ShahzaibIbrahim commented 2 months ago

https://github.com/eclipse-platform/eclipse.platform.swt/pull/1405

akoch-yatta commented 1 month ago

https://github.com/eclipse-platform/eclipse.platform.swt/pull/1506 solves the rest of this PR