search

vi-eclipse / Eclipse-Platform

Umbrella repository for managing a backlog of features/issues related to the Eclipse Platform
2 stars 0 forks source link

Replace getBoundsInPixels calls #105

Open akoch-yatta opened 3 months ago

akoch-yatta commented 3 months ago

There are still many Image::getBoundsInPixels calls in the win32 implementation. As the initial native image must be the one that will be used by a widget, we should replace that with Image::getBounds(zoom) calls, if possible

It is not necessary to replace all getBoundsInPixels calls in one PR.

ShahzaibIbrahim commented 2 months ago

Replacing getBoundsInPixels calls in GC for the images could introduce unexpected behavior. With getBounds using native zoom to scale the image. The Rectangle (100,100,100,100) with native zoom = 125, upon moving from 100 to 200 will scale up to (125,125,125,125) while getBoundsInPixels still returns (100,100,100,100).

For now we wait until we get our image class zoom sorted out. Then we can decide how to replace these calls.

ShahzaibIbrahim commented 1 month ago

Waiting for https://github.com/vi-eclipse/Eclipse-Platform/issues/122