vi-eclipse / Eclipse-Platform

Umbrella repository for managing a backlog of features/issues related to the Eclipse Platform

2 stars 0 forks source link

[Find/Replace]: Classic Dialog doesn't handle RegEx-Errors well #124

Open fedejeanne opened 1 day ago

fedejeanne commented 1 day ago

(Taken from https://github.com/eclipse-platform/eclipse.platform.ui/issues/1204)

The problem

The validation of the regular expression in the "old" search dialog (Ctrl + f in Windows) is not displayed correctly.

Criteria for ready

Evaluate options proposed in the original issue: see comment-1759145339 and comment-1759149030
Is this still an option, @Wittmaxi ? comment-1759158486
Analyze if it's possible (and how) to reuse some of the code for the other search (see comment-1759154574). At the very least, it should be possible to make the searches look similar.

fedejeanne commented 1 day ago

Maybe @jakub-suliga and/or @jannisCode would like to chat about it with @Wittmaxi and support him/take over?

Wittmaxi commented 1 day ago

@fedejeanne the mentionned issue is a good first issue for new contributors. The main issue here is in finding an expected solution - we could not yet agree on an expected behavior (it might be helpful to create a few different prototypes ?)

Moreover, the Find/Replace overlay does not offer any feedback on RegEx-Errors (thus slightly losing functionality). Maybe we can find a solution for the Overlay as well?

I am not currently planning on fixing the above issue, I believe it is an excellent issue e.g. for @jannisCode so he can quickly see first results. Feel free to reach out :)

fedejeanne commented 1 day ago

Thank you for the details, @Wittmaxi! Then I'll refine this issue and set some goals and proposals in the coming days.

Moreover, the Find/Replace overlay does not offer any feedback on RegEx-Errors (thus slightly losing functionality). Maybe we can find a solution for the Overlay as well?

I'll keep that in mind 👍