vi-eclipse / Eclipse-Platform

Umbrella repository for managing a backlog of features/issues related to the Eclipse Platform
2 stars 0 forks source link

Investigate NatTable for HighDPI #140

Closed ShahzaibIbrahim closed 1 week ago

ShahzaibIbrahim commented 2 weeks ago

Investige and adapt the NatTable (https://github.com/eclipse-nattable/nattable) in the context of HighDPI change https://github.com/vi-eclipse/Eclipse-Platform/issues/32, https://github.com/vi-eclipse/Eclipse-Platform/issues/33 and https://github.com/vi-eclipse/Eclipse-Platform/issues/34

ShahzaibIbrahim commented 1 week ago

During the testing, I have found example to be bit weird in scaling with or without HiDpi changes. In the ._102_Configuration.AutomaticRowHeightExample the image remains the same size i.e. 16px while the text and the column height is being adjusted a/c to zoom level of the current monitor. That is because of wrong implementation with GUIHelper.convertHorizontalPixelToDpi(16); which is a part of NatTable repository. Not investigating further as this is not part of HiDpi in SWT and not introduced by enabling the HiDpi feature.

Image

@HeikoKlare @akoch-yatta