Replace remaining calls to DPIUtil::get(Native)DeviceZoom()

vi-eclipse / Eclipse-Platform

Umbrella repository for managing a backlog of features/issues related to the Eclipse Platform

2 stars 0 forks source link

Replace remaining calls to DPIUtil::get(Native)DeviceZoom() #79

Open akoch-yatta opened 4 months ago

akoch-yatta commented 4 months ago

To get rid of the static device zoom in DPIUtil, we should get rid of all remaining calls to:

DPIUtil::getDeviceZoom() -> Possible replacement with DPIUtil::getZoomForAutoscaleProperty(Device::getDeviceZoom())
DPIUtil::getNativeDeviceZoom() -> Possible replacement with Device::getDeviceZoom()

Important: problematic is that Display::getDeviceZoom() calls getPrimaryMonitor() that will throw an exception when called from another thread

akoch-yatta commented 3 months ago

@amartya4256 did you cover all places of that or are some still missing?

amartya4256 commented 3 months ago

@amartya4256 did you cover all places of that or are some still missing?

Still working on it.

amartya4256 commented 3 months ago

Here we need to think about how we are gonna replace these calls from the places where the objects are initialized. One alternative could be using the primary monitor zoom from the device but it might have some issue with threads. Must have a follow up on this @akoch-yatta @HeikoKlare

fedejeanne commented 3 weeks ago

Does anyone know if there is a actually PR for this issue? If yes, please link it here.

The state "In Review" means that there is a PR, but it seems to me that this issue needs further discussion and should be moved to "New" until a decision on how to proceed has been made.

WDYT @akoch-yatta / @HeikoKlare ?

HeikoKlare commented 3 weeks ago

https://github.com/eclipse-platform/eclipse.platform.swt/pull/1401 is related to a different issue as it is supposed to replace the zoom value "correction" for non-image contexts and not to replace static usage of (native)DeviceZoom from DPIUtil, isn't it, @akoch-yatta?

HeikoKlare commented 2 weeks ago

Next step: document and investigate usages of these methods