vi-k / bubble

Speech bubble for Flutter
BSD 2-Clause "Simplified" License
266 stars 57 forks source link

Layout in iOS is invalid ? #9

Closed jasoncheng closed 4 years ago

jasoncheng commented 4 years ago

Hi,

i'm face this issue, when use install from app store, it's show large grey block. is there anything i doing worng?

-> simulator , UI is good -> plug-in device install , UI is good -> archive and release to app Store, UI is wrong.

Anyone help, please?

[✓] Flutter (Channel master, v1.15.4-pre.139, on Mac OS X 10.14.6 18G87, locale zh-Hant-TW) • Flutter version 1.15.4-pre.139 at /Users/jason/flutter • Framework revision 4df8fdb7df (2 days ago), 2020-02-22 18:24:03 -0800 • Engine revision f2f8c342be • Dart version 2.8.0 (build 2.8.0-dev.9.0 0f141be8bd)

    Flexible( 
          child: InkWell(
              onTap: () => messageClickEvent(msg),
              onLongPress: () => _showMessageMenu(context, index),
              child: RoomMgr.instance().isMessageSticker(msg) ||
                      RoomMgr.instance().isMessagePhoto(msg) ||
                      RoomMgr.instance().isMessageLocalPhoto(msg)
                  ? Container(
                      padding: EdgeInsets.fromLTRB(4, 4, 4, 4),
                      constraints: BoxConstraints(maxWidth: 200),
                      child: getGraphicMessageWidget(msg))
                  : Bubble(
                      margin: BubbleEdges.only(top: 10),
                      nip: BubbleNip.rightBottom,
                      color: Color.fromRGBO(225, 255, 199, 1.0),
                      child: Text('${msg.content}', textAlign: TextAlign.left),
                    )),
        )

flutter doctor -v

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/jason/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = /Users/jason/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.8.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.42.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (4 available)
    • iPhone 11 Pro Max • 1CF9A7D0-45B9-455F-BC83-4B722F8247D3 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
    • macOS             • macOS                                • darwin-x64     • Mac OS X 10.14.6 18G87
    • Chrome            • chrome                               • web-javascript • Google Chrome 80.0.3987.122
    • Web Server        • web-server                           • web-javascript • Flutter Tools

• No issues found!

Normal UI normal

After submit app store after-sumbit-app-store

jasoncheng commented 4 years ago

but when i change to this:

// Flexible(child:
          InkWell(
              onTap: () => messageClickEvent(msg),
              onLongPress: () => _showMessageMenu(context, index),
              child: RoomMgr.instance().isMessageSticker(msg) ||
                      RoomMgr.instance().isMessagePhoto(msg) ||
                      RoomMgr.instance().isMessageLocalPhoto(msg)
                  ? Container(
                      padding: EdgeInsets.fromLTRB(4, 4, 4, 4),
                      constraints: BoxConstraints(maxWidth: 200),
                      child: getGraphicMessageWidget(msg))
                  : Flexible(child: Bubble(
                      margin: BubbleEdges.only(top: 10),
                      nip: BubbleNip.rightBottom,
                      color: Color.fromRGBO(225, 255, 199, 1.0),
                      child: Text('${msg.content}', textAlign: TextAlign.left),
                    ))),
        // ),

it'll overflow

Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-25 at 10 58 42

jasoncheng commented 4 years ago

not a bug.

xJon commented 3 years ago

This happened to me when Bubble was in a Row.