vi-kon / laravel-wiki

Wiki Engine for Laravel 5, based on Markdown syntax
MIT License
24 stars 9 forks source link

Both illuminate/html and laravelcollective/html is installed #1

Closed amenk closed 8 years ago

amenk commented 8 years ago
 - Installing laravelcollective/html (5.2.x-dev add2c74)
   Cloning add2c74b144d0a25ba27a1506b7ce84e6bcadd64

 - Installing illuminate/html (dev-master 3d1009b)
   Cloning 3d1009bb8e0f25720c914af5c1f4015dd373c9ef

Could that cause problems?

vincekovacs commented 8 years ago

Both packages registers their services in container with same name, so this may cause problem.

By the way the illuminate/html package is abandoned and no longer maintained. The authors suggests using the laravelcollective/html package instead.

amenk commented 8 years ago

I Know. the illuminate one seems to be used in some of your own deps. so you have to change there.

vincekovacs commented 8 years ago

Oh :) Thank you, I found that vi-kon/laravel-parser-markdown uses illuminate/html, but not uses any method from it.