vi / websocat

Command-line client for WebSockets, like netcat (or curl) for ws:// with advanced socat-like functions
MIT License
6.74k stars 261 forks source link

Fix older code with cargo fix & clippy #62

Closed Br1ght0ne closed 2 years ago

Br1ght0ne commented 4 years ago

Exact actions done:


This change is Reviewable

vi commented 4 years ago

websocat 2.0 branch is already edition-2018-ed, and I prefer to keep current master (stable-ish version) stable.

Merge requests are better be directed at that branch.

Or shall I maybe rename websocat_2 to master and master to websocat_1 to avoid confusing contributors?

Br1ght0ne commented 4 years ago

Oh, I didn't know about that. Thanks for pointing out! Honestly, just setting the default branch should be enough.

I'll try to rebase this PR on websocat_2.

vi commented 4 years ago

Merged it with the master branch.

vi commented 4 years ago

Also applied cargo fix --edition --all-features --edition-idioms

Br1ght0ne commented 4 years ago

@vi Great! :tada: I basically finished the job here. cognitive_complexity needs to be addressed at a later date.