search

vi3k6i5 / flashtext

Extract Keywords from sentence or Replace keywords in sentences.
MIT License
5.59k stars 599 forks source link

test case for case-sensitive & correction in test_cases.json #24

Closed imran3180 closed 6 years ago

imran3180 commented 6 years ago

I added the test case for case-sensitive keywords and modified the keyword_extractor_test_cases.json accordingly.

"Closes #21 "

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.595% when pulling 6a8696ac422f1d44255b37992aa5c71134dd5077 on imran3180:case-sensitive-test-case into 105b24abf8b45d071f867cb20c31d0201fd28132 on vi3k6i5:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.595% when pulling 6a8696ac422f1d44255b37992aa5c71134dd5077 on imran3180:case-sensitive-test-case into 105b24abf8b45d071f867cb20c31d0201fd28132 on vi3k6i5:master.

vi3k6i5 commented 6 years ago

Fixed in flashtext-2.4.

Sorry I had to change the test case as well the json file. So I was not able to directly use your pull request. :(

I have improved the test coverage as well.

Thanks a lot for working on it, means a lot to me.. And I am really sorry I was not able to use it directly :( :(

imran3180 commented 6 years ago

Its Okay @vi3k6i5. I am sure I will find something else to contribute to this awesome repository.