search

vi3k6i5 / flashtext

Extract Keywords from sentence or Replace keywords in sentences.
MIT License
5.59k stars 599 forks source link

Fix issue with incomplete keyword at the end of the sentence #45

Closed killfactory closed 6 years ago

killfactory commented 6 years ago

While experimenting with the Flashtext performance, I've added exact check between the replacement results by different methods. By doing that, I've noticed that if the sentence ends with beginning of some keyword, that last word of sentence would be lost.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.002%) to 99.303% when pulling 599a836ba0520253e27a025c37506d4063f60403 on killfactory:master into 4d1ed199c7b4af5a645fcff15223f229098544a0 on vi3k6i5:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.002%) to 99.303% when pulling 599a836ba0520253e27a025c37506d4063f60403 on killfactory:master into 4d1ed199c7b4af5a645fcff15223f229098544a0 on vi3k6i5:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.002%) to 99.303% when pulling 599a836ba0520253e27a025c37506d4063f60403 on killfactory:master into 4d1ed199c7b4af5a645fcff15223f229098544a0 on vi3k6i5:master.

vi3k6i5 commented 6 years ago

Thanks for the fix, I will review it and merge it soon.

On Sun 21 Jan, 2018, 20:05 Coveralls, notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/15148142

Coverage increased (+0.002%) to 99.303% when pulling 599a836 https://github.com/vi3k6i5/flashtext/commit/599a836ba0520253e27a025c37506d4063f60403 on killfactory:master into 4d1ed19 https://github.com/vi3k6i5/flashtext/commit/4d1ed199c7b4af5a645fcff15223f229098544a0 on vi3k6i5:master.

—

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vi3k6i5/flashtext/pull/45#issuecomment-359252880, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-NwrARYf12vhtw2KVv9e6k6kQDw_-fks5tM0tHgaJpZM4Rl1ft .