search

vi3k6i5 / flashtext

Extract Keywords from sentence or Replace keywords in sentences.
MIT License
5.57k stars 599 forks source link

Performances improvement for strings manipulations #55

Closed rompom closed 5 years ago

rompom commented 6 years ago

Remove the +=, and use arrays and a final join. Improve the speed of the replace when dealing with huge files.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.7%) to 98.616% when pulling ac25fc344fcbc90cf5f77249ce3ae88d14f93b35 on rompom:master into 5591859aabe3da37499a20d0d0d6dd77e480ed8d on vi3k6i5:master.

smarie commented 6 years ago

Nice, thanks a lot @rompom !

smarie commented 5 years ago

@vi3k6i5 Any idea of when this PR will be merged ?

vi3k6i5 commented 5 years ago

Hi, really sorry for the delay. Got busy with some life events for the past couple of months. Will definitely look into it over the weekend. Again really sorry for the delay. Vikash

On Wed 12 Sep, 2018, 18:20 smarie, notifications@github.com wrote:

@vi3k6i5 https://github.com/vi3k6i5 Any idea of when this PR will be merged ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/vi3k6i5/flashtext/pull/55#issuecomment-420635895, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-NwjQHbMpCf1gwo8urvxKxfMAIC04Dks5uaQMHgaJpZM4UyBCl .

smarie commented 5 years ago

No worries really ! That's open source. It happens when it happens :) but at least you know that happy users are there waiting :)