search

viaacode / borndigital

Borndigital (pre-)ingests digitally born items into MediaHaven
0 stars 0 forks source link

Find CP name for fxp request via organisation_api #32

Closed maartends closed 5 years ago

maartends commented 5 years ago

In PI_SIP_DELIVERY_GENERIC_ESSENCE, the flowVar destinationPath (for the FXP-request) is being set as such: #["/" + flowVars.cp.toLowerCase() + "/TAPE-SHARE-EVENTS"] (see referenced line below), where the flowVars.cp is the value that was posted in the AMQP-message to trigger borndigital.

The CP-key in the AMQP-message, in turn, is the value for the command-line argument to the specific node-watchfolder process that sent the message to the borndigital.input queue (see documentation here: https://github.com/viaacode/node_watchfolder#arguments).

In anticipation of the switch to a folder structure on OR-id instead of CP-name on MediaHaven's transport-servers (as is already the case on the FTP-servers), borndigital should lookup the cp_name via or-id using the organisations_api, instead of relying on the value for the CP-key in the incoming message (the problem being that a different process posting a message on the borndigital.input queue might fill in a different value in the message's CP-key, which is the case for batch-intake: see here).

https://github.com/viaacode/borndigital/blob/be4abf4576e38082241f1c795723ff28a17c11ba/src/main/app/deliveries.xml#L112

maartends commented 5 years ago

[git-issue:borndigital] Find CP name for fxp request via organistaion_api

maartends commented 5 years ago

Deployed and tested. Closing.