viadee / camunda-modeler-tooltip-plugin

Add tooltips to various BPMN-elements revealing technical properties.
BSD 3-Clause "New" or "Revised" License
48 stars 10 forks source link

Business Key for Call Activity is always checked #5

Closed ingorichtsmeier closed 3 years ago

ingorichtsmeier commented 3 years ago

First, Thank you for this wonderful and very useful plugin!

I recently found a an issue with the call activities: In the overlay the business key is always checked, even if in the property panel the business key is unchecked: business-key-tooltip-plugin_LI

It's a bit confusing.

rnschk commented 3 years ago

Hi @ingorichtsmeier, thank you very much for your feedback. :)

I tried to reproduce your issue, but call-activity-elements work correctly in my setting, even if the business-key is checked and unchecked in different situations: image

image

Could you please reveal your modeler's version and maybe any extraordinary setting, or maybe even provide the respective process-model?

BR Florian

ingorichtsmeier commented 3 years ago

Hi @rnschk,

here is a process model to reproduce:

CallActivityToolTip.zip

The error appeared after adding a variable input mapping to the first Call Activity. It doesn't propagate the business key.

Kind regards, Ingo

rnschk commented 3 years ago

Hi @ingorichtsmeier, thank you. I just released v0.0.6 that should fix this issue.

The issue was caused by the variables-in-mapping used in call-activity 'CA 1'. Looking at the xml-data, one can see that both, the business-key as well as the variable mapping are written as extension-elements of type 'camunda:in', which finally lead to this behaviour.

<bpmn:callActivity id="0cfxanm" name="CA 1" calledElement="hello">
  <bpmn:extensionElements>
    <camunda:in source="1" target="1" />
    <camunda:in businessKey="#{execution.processBusinessKey}" />
  </bpmn:extensionElements>
  ...
</bpmn:callActivity>

BR Florian