search

viadee / sonarQuest

A playful approach to refactoring code smells
https://www.viadee.de/sonarquest
BSD 3-Clause "New" or "Revised" License
116 stars 28 forks source link

Gamemaster cannot create new standard tasks #31

Closed Christoph-Meyer closed 6 years ago

Christoph-Meyer commented 6 years ago

Steps to reproduce: Frontend -> Gamemaster -> Tasks -> New Standard Task (Button) Result: nothing happens Desired: Pop-up dialogue, just like "New Special Task".

sdibernardo commented 6 years ago

Feedback would be appreciated, as this is a little tricky. The TaskDto class is getting deserialized as SpecialTaskDto. That does screw up the StandardTaskDto as a deserialization exception gets thrown. We have to find a proper way to deserialize both Dtos. Suggestions are appreciated. Code can be found in the branch "issue31"

Christoph-Meyer commented 6 years ago

Testing...

Christoph-Meyer commented 6 years ago

Works partially - creation works and the newly created standard tasks appear in the list of assignable tasks when creating a Quest (OK). They do not appear in the list of standard tasks in the gamemaster view and are not searchable. Probably a caching issue @sdibernardo

Christoph-Meyer commented 6 years ago

Just checked it - yep, definately JS UI issue. Ctrl + F5 does the trick...

sdibernardo commented 6 years ago

Should we do something about it?

Christoph-Meyer commented 6 years ago

Yes, please - could you talk to @CINO-DE he might know how to trigger a refresh there.

sdibernardo commented 6 years ago

done in #78

Christoph-Meyer commented 6 years ago

To be precise: Tasks come in two different flavours, special & standard. Standard tasks can ONLY be retrieved via the SonarQube server. Special tasks can be created freely.

Issue no longer relevant. Closed.