StephenOTT
commented
6 years ago Or here is another example:
class HamcrestTestsSpec extends Specification{
@Shared BpmnModelInstance model
def setupSpec(){
model = prepModelForCoverage('bpmn/conditionalstart/HamcrestTests.bpmn') withTraits(redundantSequenceFlows)
}
def 'Redundant Sequence Flows'() {
when: 'Given a Model Definition'
then: 'Ensure there are no redundant sequence flows'
// assertThat model.doesNotContainRedundantSequenceFlows(["StartEvent_1ugw7xf":"Task_1qb2k3a"])
assertThat model.doesNotContainRedundantSequenceFlows()
}
}which will throw the following assert exception:
assertThat model.doesNotContainRedundantSequenceFlows()
| |
| java.lang.AssertionError:
| Found duplicate(s):
| <[{"StartEvent_1ugw7xf"="Task_1qb2k3a"}]>
| in:
| <[{"StartEvent_1ugw7xf"="Task_1qb2k3a"}, {"StartEvent_1ugw7xf"="Task_1qb2k3a"}, {"Task_1qb2k3a"="EndEvent_10ag13t"}]>
BpmnModelInstanceImpl1_groovyProxy@62d363abAnd if the commented out line is used instead, the assertion will pass due to the ["StartEvent_1ugw7xf":"Task_1qb2k3a"] redundancy being ignored.
key in this example is the usage of:
model = prepModelForCoverage('bpmn/conditionalstart/HamcrestTests.bpmn') withTraits(redundantSequenceFlows) which lets us apply the traits to the specific model in question. This has interesting implications for running different combinations of assertions against multiple models.
To support this functionality, the trait was updated to:
trait redundantSequenceFlows {
// https://docs.camunda.org/javadoc/camunda-bpm-platform/7.8/?org/camunda/bpm/model/bpmn/instance/package-summary.html
def doesNotContainRedundantSequenceFlows(Map<String,String> ignoredSequenceFlows = [:]){
Collection<SequenceFlow> sequenceFlows = this.getModelElementsByType(SequenceFlow.class)
ArrayList targetSource = sequenceFlows.collect {
[(it.getSource().getId()) : it.getTarget().getId()]
}
targetSource.removeAll(ignoredSequenceFlows)
assertThat(targetSource).doesNotHaveDuplicates()
}
}The idea/point of using traits here is to provide flexibility and easy readability + the ability to "technical" analysts to create new traits / re-usable assertions that match their specific use cases.
fkoehne
Hey!
been watching progress and wanted to get some insights into the work to date:
I have been working on https://github.com/camunda/camunda-bpm-process-test-coverage/issues/32 and I wanted to add the vPav style tests into the coverage testing:
Here is a working example that recreates your Redundant sequence flow test:
I decided to test out these reusable tests using Groovy Traits, so each "trait" / validation can be chosen to be added as seen fit by the testers.
see the
implements doesNotContainRedundantSequenceFlowsThe trait looks like:
I also add the ability to allow redundant sequence flows in scenarios where the BPMN may warrant duplication. see the second param of the doesNotContainRedundantSequenceFlows() method.