Make a status of all metrics and ensure homogeneity

[ecamper]

• interceptor-requests-time present for queries but missing for commands (and eventListener).
• metrics on saga missing
• there is an "unknown" dir containing empty data on errors for autowiredeventlistener source

[mglcel]

Is it possible to represent the current metrics tree provided by the framework ?

cf http://kasper-doc.viadeo.com/kasper-framework/latest/manual/Metrics.html#core-provided-metrics

[ecamper]

[cmurer]

Kasper<Query|Command>Bus

• [meter] <query-thread|command-thread>.submitted
• [counter] <query-thread|command-thread>.running
• [meter] <query-thread|command-thread>.completed
• [timer] <query-thread|command-thread>.duration

KasperEventBus

• [meter] com.viadeo.kasper.core.component.event.eventbus.KasperEventBus.submitted
• [counter] com.viadeo.kasper.core.component.event.eventbus.KasperEventBus.running
• [meter] com.viadeo.kasper.core.component.event.eventbus.KasperEventBus.completed
• [timer] com.viadeo.kasper.core.component.event.eventbus.KasperEventBus.duration

AMQPCluster

• [meter] com.viadeo.kasper.core.component.event.eventbus.AMQPCluster.<clusterName>.published
• [meter] com.viadeo.kasper.core.component.event.eventbus.AMQPCluster.<clusterName>.failed

MetricConnectionListener

• [counter] com.viadeo.kasper.core.component.event.eventbus.MetricConnectionListener.create
• [counter] com.viadeo.kasper.core.component.event.eventbus.MetricConnectionListener.close

InstrumentedErrorHandler

• [meter] com.viadeo.kasper.core.component.event.eventbus.InstrumentedErrorHandler.error

MessageHandler

• [counter] com.viadeo.kasper.core.component.event.eventbus.MessageHandler.handle-message.count
• [counter] com.viadeo.kasper.core.component.event.eventbus.MessageHandler.handle-message.error
• [histo] com.viadeo.kasper.core.component.event.eventbus.MessageHandler.handle-message.time

KasperProcessorDownLatch

• [meter] com.viadeo.kasper.core.component.event.eventbus.KasperProcessorDownLatch.submitted
• [counter] com.viadeo.kasper.core.component.event.eventbus.KasperProcessorDownLatch.running
• [meter] com.viadeo.kasper.core.component.event.eventbus.KasperProcessorDownLatch.completed
• [timer] com.viadeo.kasper.core.component.event.eventbus.KasperProcessorDownLatch.duration

<Query|Command>Handler

• [meter] client.<clientId>.<query|command>.requests
• [meter] client.<clientId>.<query|command>.errors
• [meter] <domain>.<query|command>.<inputName>.requests
• [meter] <domain>.<query|command>.<inputName>.errors
• [timer] <domain>.<query|command>.<inputName>.requests-handle-time
• [meter] <domain>.<query|command>.requests
• [meter] <domain>.<query|command>.errors
• [timer] <domain>.<query|command>.requests-handle-time
• [meter] <domain>.<query|command>.<inputName>.requests
• [meter] <domain>.<query|command>.<inputName>.errors
• [timer] <domain>.<query|command>.<inputName>.requests-handle-time
• [meter] com.viadeo.kasper.core.component.<query|command>.gateway.<Query|Command>.requests
• [meter] com.viadeo.kasper.core.component.<query|command>.gateway.<Query|Command>.errors
• [timer] com.viadeo.kasper.core.component.<query|command>.gateway.<Query|Command>.requests-handle-time

EventListener

• [meter] client.<clientId>.<event>.requests
• [meter] client.<clientId>.<event>.errors
• [meter] <domain>.eventListener.<handlerName>.handles
• [meter] <domain>.eventListener.<handlerName>.errors
• [timer] <domain>.eventListener.<handlerName>.handle-time
• [meter] <domain>.eventListener.handles
• [meter] <domain>.eventListener.errors
• [timer] <domain>.eventListener.handle-time
• [meter] <domain>.eventListener.<handlerName>.handles
• [meter] <domain>.eventListener.<handlerName>.errors
• [timer] <domain>.eventListener.<handlerName>.handle-time
• [meter] com.viadeo.kasper.core.component.event.listener.EventListener.handles
• [meter] com.viadeo.kasper.core.component.event.listener.EventListener.errors
• [timer] com.viadeo.kasper.core.component.event.listener.EventListener.handle-time

Repository

• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.saves
• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.save-errors
• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.loads
• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.load-errors
• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.deletes
• [meter] com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository.delete-errors
• [meter] <domain>.repository.<repositoryName>.save-errors
• [meter] <domain>.repository.<repositoryName>.load-errors
• [meter] <domain>.repository.<repositoryName>.delete-errors
• [timer] <domain>.repository.<repositoryName>.save-time
• [timer] <domain>.repository.<repositoryName>.load-time
• [timer] <domain>.repository.<repositoryName>.delete-time

QueryHandlerInterceptor

• [timer] com.viadeo.kasper.core.component.query.interceptor.QueryHandlerInterceptor.interceptor-requests-time
• [timer] <domain>.query.<queryName>."interceptor-requests-time"

HttpExposer

• [meter] com.viadeo.kasper.exposition.http.Http<Command|Query|Event>Exposer.errors
• [timer] com.viadeo.kasper.exposition.http.Http<Command|Query|Event>Exposer.requests-handle-time
• [timer] <domain>.<command|query|event>.<inputName>.requests-time
• [timer] <domain>.<command|query|event>.<inputName>.requests-serialization-time

+ Jetty metrics + Hystrix metrics

[mglcel]

il manque au moins déjà

• [meter] <domain>.repository.<repositoryName>.saves
• [meter] <domain>.repository.<repositoryName>.loads
• [meter] <domain>.repository.<repositoryName>.deletes

[mglcel]

on peut virer les métriques jetty, ce n'est pas du kasper à proprement parler

[mglcel]

p-e renommer

• [meter] <query-thread|command-thread|KasperEventBus>.submitted

en

• [meter] <query-thread|command-thread|event-thread>.submitted

[cmurer]

census of metrics is done

[ecamper]

:+1: merci mon Cédric

[mglcel]

• avoir un noeud 'core' ou qqchse de ce style au lieu du packageName complet
• manque [meter] client.<clientId>.<query|command>.requests-handle-time , idem pour events
• différences de métriques pas claires entre :
  • <domain>.<query|command>
  • com.viadeo.kasper.core.component.<query|command>.gateway.<Query|Command> -> idem pour eventListener
• manque times dans com.viadeo.kasper.core.component.command.aggregate.ddd.IRepository
• manque counts dans <domain>.repository.<repositoryName>
• QueryHandlerInterceptor étrange.. + il est tout seul (pas de commandHandler interceptor ?, rien côté event ?)

[mglcel]

• faire des métriques pour les SAGAs : nb starts, nb ends, liste des steps
• pour les listeners, ajouter en plus les events par type

[mglcel]

https://docs.google.com/a/viadeoteam.com/spreadsheets/d/1aqj8PpgkJl6tIdAS_YSiJ16L6rrYaz3l93gL2FR3sF4/edit?usp=sharing