search

viafintech / gcra-ruby

Generic cell rate algorithm (leaky bucket) implementation for rate limiting
MIT License
51 stars 10 forks source link

Fixing Redis warning #9

Closed diego-aslz closed 2 years ago

diego-aslz commented 2 years ago

We should now take a parameter when calling pipelined.

tobischo commented 2 years ago

Thank you for your contribution.

Could you elaborate more about which exact warning you are trying to get rid of?

While the change generally makes sense, your PR provides no real context.

tobischo commented 2 years ago

Ok, so you are referring to the redis gem version 4.6.0.

https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#460

tobischo commented 2 years ago

I have decided to implement your suggestion/the suggestion from the changelog accordingly instead of waiting for your changes

However from my perspective this is only a patch release and not a new minor version.

The change was therefore released as v1.2.1

diego-aslz commented 2 years ago

Sorry for the lack of context, thank you for implementing the fix!