search

viagogo / HalKit

A lightweight .NET library for creating and consuming HAL hypermedia APIs
MIT License
16 stars 8 forks source link

Port to CoreCLR #17

Closed TheRealPiotrP closed 6 years ago

TheRealPiotrP commented 8 years ago

Would folks be open to a CoreCLR port? It would be nice to have HalKit available for .NET developers working on Linux, Mac, etc.

akilb commented 8 years ago

@piotrpMSFT definitely. We'll get on this ourselves soon hopefully but feel free to send a pull request if you want

TheRealPiotrP commented 8 years ago

I'm working on a port in my spare cycles. It's getting pretty close already. I'll push to my fork so we can chat about it once it's building.

TheRealPiotrP commented 8 years ago

By the way, I'm seeing just one test failure:

HalKit.Tests.Http.HttpClientFactoryTests+TheConstructor.ShouldNotSetTheClientHandlerAutomaticDecompressionToNone_WhenItDoesntSupportAutoDecompression [FAIL]
      Assert.Equal() Failure
      Expected: None
      Actual:   GZip, Deflate
      Stack Trace:
           at HalKit.Tests.Http.HttpClientFactoryTests.TheConstructor.ShouldNotSetTheClientHandlerAutomaticDecompressionToNone_WhenItDoesntSupportAutoDecompression()

This doesn't seem like it would be related to what I'm doing. Is it a known issue?

akilb commented 8 years ago

@piotrpMSFT ok great. Looking forward to the pull request then.

I'm not seeing any failures for that test locally or in the CI build. Maybe there's some issue in the CoreCLR version of System.Net.Http?

TheRealPiotrP commented 8 years ago

I actually think the issue is in the Moq port.

joaope commented 8 years ago

I just saw this issue, right after created #19 for exactly it.

Btw, @piotrpMSFT and @akilb test is failing because HttpClientHandler.DecompressionMethod's default value changed on new corefx. Relevant information on the same PR.

TheRealPiotrP commented 8 years ago

Yea, I looked that up after writing to this issue and fixed in a PR that is still looking for free time :)