Move away from fbs - Githubissues

vial-kb / vial-gui

Vial is an open-source cross-platform (Windows, Linux and Mac) GUI and a QMK fork for configuring your keyboard in real time.

https://get.vial.today

GNU General Public License v2.0

909 stars 173 forks source link

Move away from fbs #39

Open Kranzes opened 3 years ago

Kranzes commented 3 years ago

Hey I was wondering if there was a possibility that this project will move away from using fbs in the near future since fbs is still using python 3.6?

Kranzes commented 3 years ago

Also updating PyInstaller to a version which isn't 2+ years old, fbs also depends on this outdated version of PyInstaller sadly.

xyzz commented 3 years ago

The plan is to eventually switch to using pyinstaller directly, unsure when I would get time to work on that though.

Kranzes commented 3 years ago

Alright so i had a discussion with the author of fbs and he doesn't have any plans on updating to anything over python 3.6, if you want to get the a newer python version which isn't insecure according to Github, you will have to pay $80 for his closed-source software that is smaller than the damn website for it. The developer seems to be very against FOSS/Open-Source.

xyzz commented 3 years ago

yes it was very disappointing that the original open source version was licensed under GPL, yet apparently there is no way to use the updated one within a GPL project

xyzz commented 3 years ago

The plan is to switch away from fbs to pyinstaller in 0.5 (so, the release after the next one).

branch to track changes: https://github.com/vial-kb/vial-gui/tree/pyinstaller

Current status:

Linux: appimage fails with "qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found."
Windows: nothing yet
macOS: nothing yet

dwlocks commented 5 months ago

I created https://github.com/vial-kb/vial-gui/pull/238 for two reasons:

The available latest download showed text too tiny to read in the main window (both the refresh button and the no keyboard found message). Menu text was normal.
My keyboard was not recognized, and I hoped updating some libs would help.

This branch updates to python 3.12, updates to latest qt5, and dependencies, removes fbs and makes things run.

It fixes my tiny text problem (1). It did not help with recognizing my keyboard (2).

I'll make whatever changes you want so you can merge these changes. I didn't test on linux or mac. I'm going to optimistically predict that linux will build with the new dependencies. :-)