vial-kb / vial-qmk

QMK fork with Vial-specific features.
https://get.vial.today/
GNU General Public License v2.0
755 stars 2.13k forks source link

Tap Term does not work for LT(1) #664

Open tomwang2011 opened 5 months ago

tomwang2011 commented 5 months ago

I have been trying to put LT(1) on spacebar such that tapping spacebar gives space and holding spacebar goes to layer 1.

According to QMK docs we should see something like: https://github.com/qmk/qmk_firmware/blob/master/docs/tap_hold.md#nested-tap-abba-idnested-tap where as long as I am within my tap term range, i press space then A gives me a. However if I hold space then tap A I should get left (I configured Layer 1 wasd to be directions).

As I am getting more left instead of a, I tried to increase the tap term under qmk settings. However even at an unrealistic 5000ms, I am still only getting left instead of a, so I think LT() probably doesn't work with tap term?

I tried the same when flashing qmk and it works fine.

refact0r commented 3 months ago

Try enabling and disabling Permissive Hold and Ignore Mod Tap Hold Interrupt and seeing if it changes anything.

pmympmm commented 2 months ago

Hi, I'm new to vial (my old keyboard used qmk and i didnt see the same - i am trying to use the same layout) but seeing something very similar to Tom. Did you figure it out @tomwang2011 ??

Vial 0.7.1 on linux/ubuntu. my keyboard is a keyclicks ergo

I would upload my config but it has a bunch of macros and things with my name and other personal bits.

I type quite quickly and my home row is usually LT keys but what I find is that I often end up with keys from layers scattered into what I type.

I have also made tapping_term much much higher and it seems to have zero effect. eg setting it to 2000 doesn't change anything. This seems repeatable with ctrl and layer modifiers.

i've tried with combinations of permissive hold & ignore mod tap interrupt but get the same.

sleeplesslord commented 1 month ago

I'm having the same problem with the Keychron Q11. The behavior of any key configured using mod tap is as if Permissive Hold is enabled even though it's disabled, and updating the tapping term doesn't seem to do anything. I tried enabling Ignore Mod Tap Interrupt and it seems to work the way I would expect now.

ntubiolin commented 1 week ago

~I'm having the same problem with the Keychron Q11. The behavior of any key configured using mod tap is as if Permissive Hold is enabled even though it's disabled, and updating the tapping term doesn't seem to do anything.~ I tried enabling Ignore Mod Tap Interrupt and it seems to work the way I would expect now.

It works for me. Thanks! Also found another explanation useful: https://reddit.com/r/olkb/comments/gmcb57/qmk_ignore_mod_tap_interrupt_documentation/