search

vial-kb / vial-qmk

QMK fork with Vial-specific features.
https://get.vial.today/
GNU General Public License v2.0
859 stars 2.5k forks source link

Setting QMK_SETTINGS to yes seems to reset AUTO_SHIFT_ENABLE to no #765

Open andruhon opened 3 months ago

andruhon commented 3 months ago

I have the following rules.mk in my layout

VIA_ENABLE          = yes
VIAL_ENABLE         = yes
LTO_ENABLE          = yes

# Enabling QMK settings takes control over things like AUTO_SHIFT_ENABLE
# I didn't yet figured out how to provide defaults for these QMK settings
QMK_SETTINGS        = yes
AUTO_SHIFT_ENABLE   = yes

RGBLIGHT_ENABLE     = no
RGB_MATRIX_ENABLE   = no # Can't have RGBLIGHT and RGB_MATRIX at the same time.
MOUSEKEY_ENABLE     = yes
OLED_ENABLE         = yes
EXTRAKEY_ENABLE     = no
COMBO_ENABLE        = no

When QMK_SETTINGS is no, autoshift works as expected, once QMK_SETTINGS is enabled it does not work after flashing and has to be enabled from UI. image

I would expect the default configuration to be picked up.

Solodros commented 2 months ago

https://github.com/vial-kb/vial-qmk/blob/vial/quantum/qmk_settings.c#L165，Change QS.auto_shift = 0; to QS.auto_shift = 1;

andruhon commented 2 months ago

Thank you @Solodros ! This change seems to solve the issue. I have created a PR using AUTO_SHIFT_ENABLE instead of 0