search

vial-kb / vial-qmk

QMK fork with Vial-specific features.
https://get.vial.today/
GNU General Public License v2.0
830 stars 2.4k forks source link

[Bug] No OLED on Sofle keyboard #94

Closed ricrug closed 2 years ago

ricrug commented 2 years ago

After flashing the keyboard with the firmware vial, the displays stay off when switching on.

xyzz commented 2 years ago

@kirbysayshi could you take a look?

kirbysayshi commented 2 years ago

I’ve used this for both sofle v1 and v2, and the OLEDs have worked for both. Could it be a seating or connection issue? Do the OLEDs work when using QMK or via?

ricrug commented 2 years ago

I’ve used this for both sofle v1 and v2, and the OLEDs have worked for both. Could it be a seating or connection issue? Do the OLEDs work when using QMK or via?

yes, it works correctly with via and the default firmware. Mine is a sofle v2. We tried it in two, on two different keyboards and from two different PCs.

kirbysayshi commented 2 years ago

My only guess is that vial changed the OLED interface and now the hook is not being called: https://github.com/vial-kb/vial-qmk/commit/9d235d4fc5c34f372b0c393f41686b5ef4f8dc13#diff-183c0f65ab3d6e9b42d26f0ce05abd45affc4d1a415d6753cdcf09d3271e6a9dR41

if you change oled.h in Sofle to return bool I bet it will work: https://github.com/vial-kb/vial-qmk/blob/7c1e1ddf53d1b077e995b23ed399e791a5e6dbcd/keyboards/sofle/keymaps/vial/oled.c#L76

ricrug commented 2 years ago

I think... it is not the only change... there's somthing wrong in the define (I forced it manually into oled.c) and it works... I'm still not able to change the logo... even if I changed the qmk_logo array.

xyzz commented 2 years ago

Should be fixed by #136