search

vialab / SMT

Simple Multi-Touch (SMT) Toolkit
http://vialab.science.uoit.ca/smt
GNU General Public License v3.0
43 stars 18 forks source link

SMT.drawSmoothTouchPoints() incorrectly uses bezier() #145

Closed ZachCook closed 10 years ago

ZachCook commented 11 years ago

Using bezier() with 4 points of the touch's path is completely incorrect.

It should instead use:

beginShape(); curveVertex(x,y); ... curveVertex(x,y); endShape();

kiwistrongis commented 11 years ago

shouldn't it be bezierVertex( x, y)?: http://processing.org/reference/bezierVertex_.html http://processing.org/reference/curveVertex_.html

ZachCook commented 10 years ago

This is the incorrect line. https://github.com/vialab/SMT/blob/master/src/vialab/SMT/SMT.java#L627

You can also close this bug if/when you redo the path drawing code.

kiwistrongis commented 10 years ago

Thanksies :)

kiwistrongis commented 10 years ago

Hey, so I tried this out, it looks pretty ugly. See my experiment branch. or this screenshot.

ZachCook commented 10 years ago

That makes a new shape for every 4 points on the path, I was thinking that it should be a single shape for the whole path, even though that might not work with the strokeweight, it might look better.

kiwistrongis commented 10 years ago

Closing. When I was playing around with this, I couldn't get it to look good. Also, the new touch drawing method has been fully implemented, making TouchDraw.SMOOTH obsolete.