search

vialer / vialer-js

Pluggable WebRTC softphone and communication platform.
MIT License
1k stars 60 forks source link

Feature/more tests #197

Closed c0deaddict closed 6 years ago

c0deaddict commented 6 years ago

Added a browser test for blind transfer. Alice calls Bob, Bob answers and then transfers the call to Charlie.

ghost commented 6 years ago

This seems to fail:

BRAND=vialer npm run test

browser] <alice> I am calling bob.
error TypeError: str is not iterable
    at Object.keypadEntry (/home/spindle/projects/vialer-js/test/browser/shared/utils.js:41:20)
    at test (/home/spindle/projects/vialer-js/test/browser/alice-calls-bob/index.js:28:17)
    at process._tickCallback (internal/process/next_tick.js:68:7)
not ok 3 exception
  ---
    operator: fail
    at: Test.test (/home/spindle/projects/vialer-js/test/browser/shared/utils.js:30:15)
    stack: |-
      Error: exception
          at Test.assert [as _assert] (/home/spindle/projects/vialer-js/node_modules/tape/lib/test.js:224:54)
          at Test.bound [as _assert] (/home/spindle/projects/vialer-js/node_modules/tape/lib/test.js:76:32)
          at Test.fail (/home/spindle/projects/vialer-js/node_modules/tape/lib/test.js:317:10)
          at Test.bound [as fail] (/home/spindle/projects/vialer-js/node_modules/tape/lib/test.js:76:32)
          at Test.test (/home/spindle/projects/vialer-js/test/browser/shared/utils.js:30:15)
          at process._tickCallback (internal/process/next_tick.js:68:7)
  ...
[11:57:12] '__test-browser' errored after 4.89 s
[11:57:12] Error in plugin "gulp-tape"
c0deaddict commented 6 years ago

Can you retry with the new vialer-jsrc file (it's on keyhub)?