viam-soleng / viam-docker-manager

Apache License 2.0
1 stars 2 forks source link

Docker run options not taking. #10

Open williamjhyland opened 6 months ago

williamjhyland commented 6 months ago

Running a docker with option "--network=host". When I do that the option isn't taking. Running docker inspect on the container I get:

"NetworkSettings": {
            "Bridge": "",
            "SandboxID": "f1e72a9f5928ea6409975877e2043270f796d50135091e042628be6e6803adc7",
            "SandboxKey": "/var/run/docker/netns/f1e72a9f5928",
            "Ports": {},
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null,
            "EndpointID": "839ec435935aeddd50f02bf5c415faa757db34a9aea0d3418128d35adc233f37",
            "Gateway": "172.17.0.1",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "IPAddress": "172.17.0.2",
            "IPPrefixLen": 16,
            "IPv6Gateway": "",
            "MacAddress": "02:42:ac:11:00:02",
            **"Networks": {
                "bridge": {**
                    "IPAMConfig": null,
                    "Links": null,
                    "Aliases": null,
                    "MacAddress": "02:42:ac:11:00:02",
                    "NetworkID": "3056f2e148f61b9f637cb06442acc40bee48e1c2b977834d096d0582e072df1e",
                    "EndpointID": "839ec435935aeddd50f02bf5c415faa757db34a9aea0d3418128d35adc233f37",
                    "Gateway": "172.17.0.1",
                    "IPAddress": "172.17.0.2",
                    "IPPrefixLen": 16,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "DriverOpts": null,
                    "DNSNames": null
                }
            }
        }

However if I run docker run --rm --network=host ubuntu@sha256:e6173d4dc55e76b87c4af8db8821b1feae4146dd47341e4d431118c7dd060a74 sleep 100000

which should be the same command.... I get

        "NetworkSettings": {
            "Bridge": "",
            "SandboxID": "98bc1dc97af5f8f4a5e8f2fda32c2c7d4d1e1cd28d2d634b80d296190d703f66",
            "SandboxKey": "/var/run/docker/netns/default",
            "Ports": {},
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null,
            "EndpointID": "",
            "Gateway": "",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "IPAddress": "",
            "IPPrefixLen": 0,
            "IPv6Gateway": "",
            "MacAddress": "",
            **"Networks": {
                "host": {**
                    "IPAMConfig": null,
                    "Links": null,
                    "Aliases": null,
                    "MacAddress": "",
                    "NetworkID": "38bcd950654cb61ec5065fe30350c48de24f2bb2a8f08fca1f338e55d769ec64",
                    "EndpointID": "fb7019ae34e5689125d018cf4268e8a082fec1a1b6b2321dcc9fad05930a24f1",
                    "Gateway": "",
                    "IPAddress": "",
                    "IPPrefixLen": 0,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "DriverOpts": null,
                    "DNSNames": null
                }
            }
        }
williamjhyland commented 6 months ago

Appears we need to add this to the config: https://pkg.go.dev/github.com/docker/docker@v26.0.0+incompatible/api/types/network#EndpointSettings