search

vianpl / mcp2210

MCP2210 USP to SPI master & GPIO evaluation drivers
GNU General Public License v2.0
2 stars 3 forks source link

Improved driver for TC77 & Kconfig snipppet. #1

Open henri62 opened 4 years ago

henri62 commented 4 years ago

I did some tests with the driver you have here in your github archive and found some issues (even without having the hardware). One issue is that the conversion is never started on the first place because the 'next_update' is not initialized in the probe. The other issue is that the actual calculation is incorrect as far as I could see, I fixed that, but due to the lack of the actual chip I was not able to really test that, I only emulated the chip values.

So do you still have the hardware available? If yes, could you test the new driver? If correct, could you please update the driver in this archive and try to make a pull request to get it in the linux mainline archive?

The entire new driver is attached, including the Kconfig snippet. tc77.zip -edit- Fixed a warning in the driver.

vianpl commented 4 years ago

Hi @henri62 , thanks for getting in touch.

Sadly I don't have access to the HW anymore, so I can't test it nor send the patch into mainline Linux. That said I'll find a moment to review your changes and integrate them into the driver.

henri62 commented 4 years ago

Thanks for the reply. I have a board here where such a chip can be added too but its not assembled on all our boards, its an option. Next week I'll ask someone if we do have a board somewhere where this chip is truly assembled. If not, I need to order a part and solder it on a board myself and check it.

I will keep in touch if the test succeeds and edit the issue I submitted. Regards, Henri

On Fri, Jun 5, 2020 at 11:59 AM Nicolas Saenz Julienne < notifications@github.com> wrote:

Hi @henri62 https://github.com/henri62 , thanks for getting in touch.

Sadly I don't have access to the HW anymore, so I can't test it nor send the patch into mainline Linux. That said I'll find a moment to review your changes and integrate them into the driver.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vianpl/mcp2210/issues/1#issuecomment-639380903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDWDQRDLBYGJJR5X67NOXTRVC6ZJANCNFSM4NTL4V4A .

vianpl commented 4 years ago

If you manage to get it tested, I don't mind taking care of refactoring/submitting it upstream, but only the bits you actually tested.