viant / toolbox

Toolbox - go utility library
Apache License 2.0
197 stars 29 forks source link

paths are wrong on windows #22

Closed langohr closed 5 years ago

langohr commented 5 years ago

If you are using this toolbox with windows the path are not correct.

The reason is, that you are using import "path" instead of import "path/filepath"

could you change fileset_info.go line 488 to

filename := filepath.Base(filename)

and add the import

import "path/filepath"

langohr commented 5 years ago

@adranwit Could you please fix that?

adranwit commented 5 years ago

Patched, Thanks, Adrian

adranwit commented 5 years ago

Please let me know if a patch worked for you, otherwise, I will close the issue in 24 hours,