search

viant / toolbox

Toolbox - go utility library
Apache License 2.0
197 stars 29 forks source link

TestWaitTimeout_TimeoutTriggered fails at go test #28

Closed rogers0 closed 4 years ago

rogers0 commented 4 years ago

Hi there,

I'm working with @creekorful to package this project into Debian. Debian build system usually run go test after building the package, so I find TestWaitTimeout_TimeoutTriggered fails, whatever has network access. Here's the log:

=== RUN   TestWaitTimeout_TimeoutTriggered
    TestWaitTimeout_TimeoutTriggered: waitgroup_helper_test.go:19:
                Error Trace:    waitgroup_helper_test.go:19
                Error:          Not equal:
                                expected: true
                                actual  : false
                Test:           TestWaitTimeout_TimeoutTriggered
--- FAIL: TestWaitTimeout_TimeoutTriggered (0.00s)
adranwit commented 4 years ago

patched issue

rogers0 commented 4 years ago

I'm sorry that this issue still occurs on version 0.32.2, but just sometimes. (Yes, sometimes it can pass.) Here's the log when it fails:

=== RUN   TestWaitTimeout_TimeoutTriggered
    TestWaitTimeout_TimeoutTriggered: waitgroup_helper_test.go:20:
                Error Trace:    waitgroup_helper_test.go:20
                Error:          Not equal:
                                expected: true
                                actual  : false
                Test:           TestWaitTimeout_TimeoutTriggered
--- FAIL: TestWaitTimeout_TimeoutTriggered (0.00s)
rogers0 commented 4 years ago

could you kindly reopen this ticket? thank you!

rogers0 commented 4 years ago

I confirm this issue, TestWaitTimeout_TimeoutTriggered, still fails sometimes on latest 0.33.0 although I disabled this test, so it won't shown on reproducible builds.

adranwit commented 4 years ago

Patched race condition

rogers0 commented 4 years ago

@adranwit Thanks! I confirmed by [ad4995d] the test can be passed, on 0.33.0-9.

So closing this ticket.