search

viascom / nanoid-kotlin

Nano ID for Kotlin
Apache License 2.0
16 stars 1 forks source link

Make the library Multiplatform and upgrade config #11

Open HLCaptain opened 4 months ago

HLCaptain commented 4 months ago

I would like to use this library in multiple Kotlin Multiplatform projects of mine, but only JVM is supported. I found a crypto library, which implements SecureRandom, as well as multiple stable random libraries across other platforms to be used in common code.

The modification also comes with configuration change to using Kotlin Gradle DSL.

I already forked this repository and made my changes (not finalized yet).

HLCaptain commented 3 months ago

Just so we don't duplicate work, @nik-sta should I attempt to finish up my changes and make a PR, or is it your task to find a proper way to make the library multiplatform? Either way, I am happy to assist and make changes! :)

nik-sta commented 3 months ago

Hi, @HLCaptain. Thanks for taking the time to discuss your changes with us. Generally speaking, we like your proposal and code changes. The one detail we need to work on (or make up our minds) is whether there is an alternative for the crypto library. The proposed one is unacceptable and insufficient to accept using it, as we aim to use standards and well-established libraries only.

You are more than welcome to contribute to this repo; therefore, please make your pull request, and we can work together on it :)

Using only the cryptography-random module, as it is nicely structured, would be one improvement, but as it is currently in version 0.3.0 and relatively new, it remains a risk.

itsmefox commented 3 months ago

We would highly welcome the change to make this library multiplatform capable. Let's find a way together to make this possible.