Avoid duplicate code when unsetting multiple boolean arguments - Githubissues

viash-hub / biobox

🌱📦 A collection of bioinformatics tools for working with sequence data.

https://web.viash-hub.dev/package/biobox

MIT License

4 stars 6 forks source link

Avoid duplicate code when unsetting multiple boolean arguments #133

Closed DriesSchaumont closed 3 months ago

DriesSchaumont commented 3 months ago

Description

Avoid duplicate code when unsetting multiple boolean arguments

Issue ticket number

~Closes #xxxx~

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Conforms to the Contributing guidelines
[x] Proposed changes are described in the CHANGELOG.md
[x] I have tested my code with viash ns test --parallel -q <name or namespace>
Check the correct box. Does this PR contain:
- [ ] Breaking changes
- [ ] New functionality
- [ ] Major changes
- [x] Minor changes
- [ ] Documentation
- [ ] Bug fixes

DriesSchaumont commented 3 months ago

Not entirely in favour of this since I tend to prefer code that is easier to understand in this specific repo. However I do agree that higher level code results in fewer bugs ☺️
* Could you revert changes when the component only has one flag?

* Could you add an entry to the changelog?

* Can you add something to the contrib guidelines ?

CHANGELOG en contributing entries were already added 😃 Also, I did not apply this change to any component with only one flag (perhaps you were looking at the contribution guidelines?).