Add star solo component - Githubissues

viash-hub / biobox

🌱📦 A collection of bioinformatics tools for working with sequence data.

https://web.viash-hub.dev/package/biobox

MIT License

4 stars 6 forks source link

Add star solo component #62

Closed rcannood closed 4 months ago

rcannood commented 5 months ago

Description

BREAKING CHANGES

star/star_align_reads: Change all arguments from --camelCase to --snake_case (PR #62).
star/star_genome_generate: Change all arguments from --camelCase to --snake_case (PR #62).

NEW FUNCTIONALITY

star/star_align_reads: Add star solo related arguments (PR #62).

Issue ticket number

Closes #xxxx

Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] Conforms to the Contributing guidelines
[ ] Proposed changes are described in the CHANGELOG.md
[ ] I have tested my code with viash ns test --parallel -q <name or namespace>
Check the correct box. Does this PR contain:
- [ ] Breaking changes
- [x] New functionality
- [ ] Major changes
- [ ] Minor changes
- [ ] Documentation
- [ ] Bug fixes

rcannood commented 4 months ago

@DriesSchaumont I'm strongly considering dropping the star solo component and just adding the missing arguments to the main star_align_reads component. WDYT?

DriesSchaumont commented 4 months ago

@DriesSchaumont I'm strongly considering dropping the star solo component and just adding the missing arguments to the main star_align_reads component. WDYT?

Yes, I agree... Its complicated already ^^

rcannood commented 4 months ago

Done! @DriesSchaumont Care to re-review?