viash-io / viash

script + metadata = standalone component
https://viash.io
GNU General Public License v3.0
39 stars 2 forks source link

[BUG] A VDSL3 module does not handle `multiple: true` outputs properly #638

Closed tverbeiren closed 7 months ago

tverbeiren commented 9 months ago

What happened?

Setting multiple: true on an output generates an error:

ERROR ~ No such variable: destPath

This error is generated in the publishStatesProc process. The issues arise in the publishStates.nf source that is included in the generated module.

Steps to reproduce

See multiple_output unit test in under src/test/resources/testnexrtflowvdsl3/src.

Expected behavior

The directory should be created.

Relevant log output

No response

Version

Viash 0.8.0 and above

Possible solution

The solution is to fix line 187 in publishSteates.nf.

Confirmation

Additional context

No response

tverbeiren commented 9 months ago

For a fix, see: https://github.com/viash-io/viash/pull/639

Grifs commented 7 months ago

Fixed in Viash 0.8.6