Fix an issue where if the first resource is not a script, the resource is silently dropped

Grifs commented 7 months ago

Describe your changes

Related issue(s)

Closes #650

Type of Change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New functionality (non-breaking change which adds functionality)
[ ] Major change (non-breaking change which modifies existing functionality)
[ ] Minor change (non-breaking change which does not modify existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

Checklist

Requirements:

[x] I have read the CONTRIBUTING doc.
[x] I have performed a self-review of my code by checking the "Changed Files" tab.
[x] My code follows the code style of this project.

Tests:

[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Documentation:

[x] Proposed changes are described in the CHANGELOG.md.
[ ] I have updated the documentation accordingly.

Test Environment

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.76%. Comparing base (6fcf7b6) to head (72f9fc6).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop_0_8 #670 +/- ## ============================================ Coverage 88.76% 88.76% ============================================ Files 120 120 Lines 3630 3630 Branches 526 526 ============================================ Hits 3222 3222 Misses 408 408 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Grifs commented 7 months ago

LGTM! Minor suggestion

Right, I was thinking of other edge cases ... which totally don't happen in Scala :stuck_out_tongue:

viash-io / viash