fix the dependency.name example - Githubissues

viash-io / viash

script + metadata = standalone component

https://viash.io

GNU General Public License v3.0

39 stars 2 forks source link

fix the dependency.name example #697

Closed Grifs closed 4 months ago

Grifs commented 5 months ago

Describe your changes

Change the dependency.name example. Also change how Either is output in the niceType. Will require an update of the jinja template on the website.

Related issue(s)

Closes #xxxx

Type of Change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New functionality (non-breaking change which adds functionality)
[ ] Major change (non-breaking change which modifies existing functionality)
[ ] Minor change (non-breaking change which does not modify existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

Checklist

Requirements:

[ ] I have read the CONTRIBUTING doc.
[ ] I have performed a self-review of my code by checking the "Changed Files" tab.
[ ] My code follows the code style of this project.

Tests:

[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.

Documentation:

[ ] Proposed changes are described in the CHANGELOG.md.
[ ] I have updated the documentation accordingly.

Test Environment

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.90%. Comparing base (9820541) to head (be046df). Report is 10 commits behind head on develop_0_8.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop_0_8 #697 +/- ## =============================================== + Coverage 88.78% 88.90% +0.11% =============================================== Files 120 120 Lines 3648 3676 +28 Branches 527 552 +25 =============================================== + Hits 3239 3268 +29 + Misses 409 408 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.