viash-io / viash

script + metadata = standalone component
https://viash.io
GNU General Public License v3.0
36 stars 2 forks source link

Add package name in the docker image name #712

Closed Grifs closed 3 weeks ago

Grifs commented 1 month ago

Set DockerEngine package and organization default from package config

Describe your changes

Related issue(s)

Closes #713

Type of Change

Checklist

Requirements:

Tests:

Documentation:

Test Environment

Grifs commented 4 weeks ago

.organization is removed from the component config. (Can still be undone easily)

So far no additional fallback was added in case the .organization in package config is empty.

Grifs commented 3 weeks ago

Would you like to add the changes suggested by comment #2 ?

You mean this part?

    val targetRegistryWithFallback = target_registry.orElse(config.links.docker_registry).filter(_.nonEmpty)

If so, this is already present. If something else, could you please elaborate?

rcannood commented 3 weeks ago

LGTM!