Fix docker_engine - Githubissues

viash-io / viash

script + metadata = standalone component

https://viash.io

GNU General Public License v3.0

39 stars 2 forks source link

Fix docker_engine #722

Closed Grifs closed 3 months ago

Grifs commented 3 months ago

Describe your changes

Related issue(s)

Closes #xxxx

Type of Change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New functionality (non-breaking change which adds functionality)
[ ] Major change (non-breaking change which modifies existing functionality)
[ ] Minor change (non-breaking change which does not modify existing functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

Checklist

Requirements:

[x] I have read the CONTRIBUTING doc.
[x] I have performed a self-review of my code by checking the "Changed Files" tab.
[x] My code follows the code style of this project.

Tests:

[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Documentation:

[x] Proposed changes are described in the CHANGELOG.md.
[ ] I have updated the documentation accordingly.

Test Environment

Grifs commented 3 months ago

Note: It might look odd in the changes, but there is already a check whether the config and namespace_separator are both Some(...) or None. If we map the config.namespace, we know it isn't None, therefore namespace_separator isn't None either.