Sanitize logging across all components

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org

http://eclipse.org/viatra

13 stars 4 forks source link

Sanitize logging across all components #137

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago

the goal is to avoid having two different kinds of loggers
- factor out a common logger logic into .runtime
- used by RETE
- used by Generator
log methods shall support multiple sources and multiple targets
- multiple sources: to be able to distinguish between Generator, RETE messages etc.
- multiple targets: multiple loggers (system.out, eclipse log)
solution is that the logger should be injected into the engine

@ujhelyiz promised to help with this

bergmanngabor commented 12 years ago

run-time messages (caught exceptions) should be detected by tests as opposed to simply being printed to the default logger (stderr).

bergmanngabor commented 12 years ago

After reading up on the hierarchical nature of log4j, I now have the impression that instead of passing around a global Logger instance, we were supposed to use e.g. Logger.getLogger(ThisClass.class) everywhere, and then separately apply filters and appenders at arbitrary points along the package namespace hierarchy (e.g. "org.eclipse.viatra2.emf.incquery"). We should discuss this.

Anyway, for now engine and dependant components were adjusted in 3f5ff22ace9942124a606a3eab939739fc4406fb

ujhelyiz commented 12 years ago

Yes, that is true. However, log4j vs. OSGi vs. Xtext log4j configuration are really tricky to setup. Basically, we have to turn off the configured Xtext logger (it get's applied automatically to all of our editors, and that causes the org.apache.log4j plug-in logger entries in the Error log view).

In other words, you are right, but that way it does not work.

ujhelyiz commented 12 years ago

Seems to be fixed. If some issue comes forth, it should be handled on a case-by-case basis. Currently marking as resolved.