viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Make pattern registry UI display patterns according to namespace hierarchy #142

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago

Instead of the flat list, I would like the pattern registry UI to display patterns like the package explorer (i.e. checkbox tree, but the packages should be "compressed").

Also, if one registers patterns, the pattern registry drawer should automatically open from the left, to show the newly registered patterns.

Also, the Details/Filters drawer should be visible by default.

szabta89 commented 12 years ago

I'm working on this issue, but it is a bit complicated.

szabta89 commented 12 years ago

8d7b3a6b3ce70565fc200095504455b0f519cc8f

istvanrath commented 12 years ago

An additional request: it would be useful to add the ability to unregister multiple patterns in one go (e.g. by allowing multi-select).

szabta89 commented 12 years ago

I use CheckboxTreeViewer for the issue, and I think it does not support multiple selection. Maybe, @ujhelyiz knows some other SWT widget that can deal with multiple selection. As an alternative solution, I have implemented the pattern unregistration to handle multiple unregistrarions, ie. when selecting an element from some upper hierarchy level.

Note that the implementation is not fully functioning atm.

ujhelyiz commented 12 years ago

Most (if not all) JFace viewers support multiple selection by adding the SWT.MULTIPLE or some similar style bit to the constructor. And because a Table is the underlying widget for the CheckboxTreeViewer, this should work.

istvanrath commented 12 years ago

Can you implement the "Package presentation / Flat" behaviour from the Package Exporer?

szabta89 commented 12 years ago

I need some ideas here, as I think you want to see these buttons on the flyout of Pattern registry itself, not on the "triangle" of the Query Explorer's view. I searched around but could not really find anything how to solve this drop down on a composite.

szabta89 commented 12 years ago

I think this functionality is complete and close the issue. If further problems would appear please open an individual issue.