search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Make magical green button work with Graphiti editors #153

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago

At the moment, I can't seem to get the magical green ("play") button to load instance models from Graphiti editors. I have tried with http://www.eclipse.org/proposals/soa.bpmn2-modeler/ and it just doesn't work.

szabta89 commented 12 years ago

I do not know the mentioned project. Does it have an editor to build bpmn models? I think the reason will be that its editor is not an instance of IEditingDomainProvider, but I will investigate it.

At the moment, I can't seem to get the magical green ("play") button to load instance models from Graphiti editors. I have tried with http://www.eclipse.org/proposals/soa.bpmn2-modeler/ and it just doesn't work.

Reply to this email directly or view it on GitHub: https://github.com/ujhelyiz/EMF-IncQuery/issues/153

ujhelyiz commented 12 years ago

A major refactor is done to the corresponding code - GMF editors should be available when installing the available GMF Extensions feature (it is not included in the SDK because of the extra dependency).

Additionally, the existing handler is reworked into two separate handlers with corresponding activeWhen conditions. Although this seems more complex scenario, it allows extensibility, including the setup of more specific loaders for some editors (if needed), and the additional feature that the button becomes disabled if there is nothing to load for it.

abelhegedus commented 12 years ago

Edited issue description as GMF editors work now.

szabta89 commented 12 years ago

@istvanrath I just played with Graphiti editors and noticed that the current version is able to load the domain model properly as the Graphiti Diagram Editor is also an IEditingDomainProvider instance. However, it just does not make sense to present the 'Load resource' button for a Graphiti editor because one can not select "parts of the whole resource set".

istvanrath commented 12 years ago

@szabta89 I don't understand " one can not select parts of the whole resource set." Why do you link "Load resource" doesn't make sense for Graphiti?

ujhelyiz commented 12 years ago

Commits bf2017346e8f51cb29191aa70e671d64d53ced46, b50c8c9f1ac6de6414301ff90d87f1418314f87b, 50f2a04b965907e8769dda39928d877990abf1a1, 9651011eb1428bdaf452ae376d834297b061517e and af14b0113fcd763ae6966c00cf845de7a1c7c932 are related to this issue.

@szabta89, please mark further commits related to this issue with the issue number.

szabta89 commented 12 years ago

The previous commits solve the Graphiti handler conflict problems and now both gmf and graphiti handlers work properly.

ujhelyiz commented 12 years ago

Removing resolved tag - not in the build yet.

ujhelyiz commented 12 years ago

Now this feature is available in the build.